Re: [Linuxsampler-devel] cancel release on note on?

[Christian S. <sch...@so...>]

Es geschah am Sonntag 05 Dezember 2004 15:22 als Andreas Persson schrieb:
> Christian Schoenebeck wrote:
> > ProcessControlChange() only handles the sustain pedal case.
> > ProcessNoteOn() handles the case when the same key was triggered
> > instantly after releasing the same key. So this make sense.
>
> Sorry for being so stubborn, but I'm not sure I understand when the
> second case adds any realism?

There's nothing to excuse, doubts are often productive.

I guess you don't see a realism, because you assume the 2nd key trigger causes 
a new voice of approx. the same amplitude or even higher than the first one. 

But imagine the following case: you trigger key C3 the first time with a 
velocity of 127, then you release key C3 and immediately after that press C3 
again, but this time with a velocity of 1.

If we do what you claimed and remove those lines, you will hear nothing on the 
2nd key trigger. With current implementation though you still here the first 
voice. Which makes sense, doesn't it?

> > Again, we can make that a compile time option if you like.
>
> OK, but what will be the default? :)

I vote against that being the default behaviour. But of course if I'm alone 
with that opinion I accepted it even as default behaviour.

CU
Christian