Re: [Linuxsampler-devel] Build failure: probable gcc-3.4.1 issue?

[Rui N. C. <rn...@rn...>]

Hi Christian,
>
> I don't have gcc 3.4 but I'm surprised about some things,
> e.g. why gcc 3.4 insists on some of these "this->" pointers and
> e.g. the #include <errno.h> in rtelmemory.h.
>

Beats me :)

I'm also puzzled with th "this->" issue too. The compiler just kept
complaining that those inherited protected variables weren't being
declared.

The included "errno.h"s were needed, most probably because it isn't being
implicity included anymore by some other header file. gcc-3.4 include file
structure has perhaps changed, but not sure.


> But the patch is ok, of course. I'm not yet sure when I'll commit my
stuff, cause I'm still fighting with some problems, so please go ahead and
commit it.
>

OK. I'll apply it tonight.


On another subject, I noticed that linuxsampler maps MIDI channels number
in a off-by-one difference to ALSA sequencer numbering, which equals the
native low MIDI command address level. I think the following table shows
this mismatch:

MIDI     MIDI
channel  channel
address  number   linuxsampler  alsa-seq
-------  -------  ------------  --------
0        1        All channels  0
1        2        1             1
2        3        2             2
...      ...      ...           ...
15       16       15            15

That is, 0 (zero) means "All channels" to
linuxsampler(MidiInputPort::midi_chan_all), but for ALSA and low-level
MIDI for this matter, it's the valid MIDI channel address 0 (zero), or
MIDI Channel 1 (one).

Moreover, the "All channels" linuxsampler specification doesn't seem to
work at all, being just single mapped to MIDI Channel 1 (address 0).

So I would ask, what's the status for this "All channels" (omni?) mode? It
doesn't seem to be implemented in MidiInputPort, where I think it should
be. Additionally, I think this MIDI channel numbering should be
explicitly, if not, better documented.

For example, the LSCP command SET CHANNEL MIDI_INPUT_CHANNEL assumes MIDI
channels being given in the range 1-16. Or so I think (the RFC document is
not explicit on that). However, the "ALL" channels" mode is clearly
mentioned.

Any comments?
-- 
rncbc aka Rui Nuno Capela
rn...@rn...