[Linuxsampler-devel] Load Instrument patch (2)

[Rui N. C. <rn...@rn...>]

Hi,

Second round. In the attachment there's a cleaned up version for LOAD
INSTRUMENT / GET CHANNEL INFO commands diff-patch, which is supposed to be
applicable to current linuxsampler CVS HEAD (patch -p1).

If nothing stands against, I'll may commit it soon, while testing the
latest bleeding-edge server code and updating the LSCP document-draft.

>
> Specifically, this patch makes the LOAD INSTRUMENT command to return
> immediately, almost/always with an "OK" response, while spawning the
> proper instrument file loading in the background.
>
> The new INSTRUMENT_STATUS item from GET CHANNEL INFO inquiry command is
> where one checks for a successfull load. The instrument status value holds
> the load progress percentage if positive, currently only "0" and "100" ;)
> Otherwise, in case of a load exception error, the instrument status
> variable will hold a negative value.
>
> As proposed, the instrument file load is considered successful and
> complete when and only when INSTRUMENT_STATUS holds a "100" value.
>
>>   If all this is OK, I can make the changes myself to the draft
>> document. Yet again, it will bump to v.09. The summary preview of
>> changes are:
>>
>>   4.4.1 LOAD INSTRUMENT slight semantics change;
>>   4.4.9 GET CHANNEL INFO response new status field, INSTRUMENT_STATUS;
>>   6.6 INSTRUMENT_LOADING event type simply vanishes away.
>>
>
> Just hoping this patch gets tested and reviewed, and ultimately found
> applicable, I'll start making the document changes in no time.
>

BTW, the current CVS HEAD linuxsampler server it's pretty unstable
nowadays, as I find it segfaulting on any ocasion I try to load an
instrument file. These crashes are highly reproducable, whether this patch
is applied or not. So don't start flaming about that :)

Likewise, qsampler is being always brought to the floor, being quite
unusable at this moment with the latest server CVS. Despite server's
crashing quite deterministicaly, these client issues are being taken care
on the liblscp side, so soon this may improve a liltle.

Hope to hear your comments. Is everybody left on exams ? ;)

Take care.
--
rncbc aka Rui Nuno Capela
rn...@rn...