Re: [Linuxsampler-devel] gigaedit saving issues

[David S. <dav...@gm...>]

 > Considered fixed in Gigedit 1.2.2.svn2.

Thanks a lot for fixing this so quickly!

I tried the latest snapshot (2.4.0.svn1_20250914) and noticed two things 
with gigaedit when saving a giga studio file:
1. Saving any file under a new name brings up a warning dialog saying 
something along the lines of "Could not import the following sample(s): 
libgig error: could no (re)open the file "C:\path\to\newly saved 
file.gig" in read-write mode
2. Opening this ~70MB file (original gig file from the SI Symphonic 
Brass Collection) and just saving it under a new name produces a huge 
10GB gig file: https://owncloud.gwdg.de/index.php/s/KbngKGggApKN8Zt

Let me know if this mailing list is still the appropriate channel for 
reporting bugs.

Best,
David

Am 09.09.2025 um 18:04 schrieb Christian Schoenebeck:
> On Monday, September 8, 2025 11:32:13 PM CEST David Schornsheim via
> Linuxsampler-devel wrote:
>> Hello,
>>
>> there's an issue with the current version of gigaedit (tested on Windows
>> 10 and on Linux) with version 2.4.0.svn1_20250906.
> [...]
>> For Andreas Persson, even the latest version still crashes when saving:
>>> * Start gigedit,
>>> * add a region,
>>> * add a sample (24 bit, 48kHz),
>>> * assign the sample to the region,
>>> * save the gig file (with a new file name)
>>> => crash
>>>
>>> Interestingly, this happens on Linux too, so it's not Windows specific.
>>>
>>> It crashes because RIFF::Chunk::Write throws this exception: "Cannot
>>> write data to chunk, file has to be opened in read+write mode first". I
>>> don't know why. There were many changes in this area of the code in
>>> February 2025. We should let Christian know about it.
> 
> Right, this was completely system agnostic.
> 
> I just committed two fixes for this:
> 
> https://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=4366
> https://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=4367
> 
> On the long term it makes sense to move the sample import into the file saver
> thread, then all the gig file save code would run on the same background
> thread, but for now that fix is trivial enough.
> 
> Considered fixed in Gigedit 1.2.2.svn2.
> 
> Thanks!
> 
> /Christian
> 
> 
> 
> 
> _______________________________________________
> Linuxsampler-devel mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel