From: Christian S. <sch...@li...> - 2025-06-11 10:28:47
|
On Tuesday, June 10, 2025 11:52:32 PM CEST Rui Nuno Capela via Linuxsampler- devel wrote: > On 6/10/25 22:11, Christian Schoenebeck wrote: [...] > > I saw that you also added an optional installation of Qt onto the system. > > While that probably makes sense for Windows, on a Mac the common way is to > > just include the required Qt libraries (as "frameworks") with qsampler's > > app bundle (i.e. inside that "qsampler.app" directory). > > so you think that's superfluous? > > just say yes and I'll remove that as unnecessary... Hmm, after reading the Qt documentation on this, I realized the purpose of windeployqt / macdeployqt is something else. I thought it was a Qt installer. It is not. It is run against a compiled Qt application binary (e.g. qsampler.exe) and it would modify the executable (replacing absolute DLL paths by relative ones) and adds all required Qt libraries to the directory of the executable so that the Qt executable would run *without* installing Qt. I am not sure where you got that CMake block from, apparently this block is just run if CONFIG_INSTALL_QT was explicitly set by the user from the command line? I would leave it there for now. It might be useful in future when we change the entire installation packages to work with pure app bundles (i.e. to allow installing without admin permissions in future and avoiding DLL version conflicts). /Christian |