Re: [Linuxsampler-devel] ADSDR 6th try

[Vladimir S. <ha...@so...>]

Mark,

Are you still getting hiss that you were getting before?
If so, could you try to pull LS from CVS and rebuild and test if it is 
still there? If so, it may have something to do with jack support or 
other non-adsdr related changes. If you are only getting that after you 
apply adsdr patch then it must be something that came with the patch and 
i'll be happy to investigate.

Any other feedback on that adsdr patch? I have a semi free weekend ahead 
and should be able to fix bugs or rewrite it completely depending on how 
bad it is :) Or maybe clean up the code and get it ready for check in?
If anyone has time to review the code that would be greately appreciated.

Also, if there are no objections, i could look into those enhancement 
requests that Mark made at the bottom of the e-mail. Should be pretty 
straight forward i assume, but i don't want to do that if someone is 
already looking into it :)

Regards,
Vladimir.

Mark Knecht wrote:

>On Sun, 2004-01-18 at 17:22, Vladimir Senkov wrote:
>  
>
>>Mark,
>>Last e-mail :)
>>
>>Few small things here but mostly to try out a hack to implement 
>>"re-sustain" effect we talked about earlier.
>>For now, just a "proof of concept", it will be coded differently. for 
>>now i just created a global because there is no easy way to link sustain 
>>to voices after ProcessNoteOff().
>>Let me know how it feels with different samples. My impression is that 
>>it sounds fairly accurate with samples that have infinite sustain 
>>disabled (such as that free Steinway sample i'm using), but perhaps a 
>>bit too strong with infinite sustain samples such as Church Organ for 
>>example.
>>I'm thinking about making that second sustain stage non-infinite just 
>>like decay2 even for samples with infinite sustain. Any thoughts on this?
>>I'll test it with GS next weekend to see how it does it with different 
>>samples.
>>
>>Regards,
>>Vladimir.
>>
>>PS: patch is not incremental. Apply to latest CVS.
>>    
>>
>
>Vladimir & Christian,
>   OK, I've installed today's CVS with ADSDR6. It seems to be working
>fine so far. It correctly determines if Jack is running. If Jack is not
>running it does what it did before. However, I needed to edit
>audioio.cpp before and what I needed to edit appears to have moved.
>Could I make my first simple enhancement request? Could we have a
>command line option to tell it which sound card to use? Earlier I was
>changing plughw:0 to plughw:1. Could the number be changed to be a
>command line option? (--card "plughw:1")
>
>  If Jack is running it connects to the the Jack server, but it doesn't
>connect the audio path automatically. Could I make my second request to
>have a command line option to make this connection? (--jack-ch
>"playback_1, playback_2" - I.e. don't forget stereo vs. mono...) 
>
>   Also, I think it would be helpful to have LS print some sort of
>revision info when it starts. I have so many versions now I'd like to be
>sure when I install a new version that I'm really using it. ;-)
>
>   OK, with that all behind me it appears that LS is working well with
>Jack. No clicks of pops so far. The only negative thing I've noticed so
>far is that with a lot of notes playing I seem to be getting a lot of
>hiss in the background. As the notes die away the hiss goes away, so it
>appears to be part of the sample, but in LS I *think* I'm getting a lot
>more hiss now? Could this be part of the ADSDR edit, or could it have
>something to do with using Jack?
>
>   I need to go back and find the code that moved so that I can use my
>HDSP 9652 without Jack, or wait for you all to add the card choice
>enhancement. 
>
>   I'll start playing with more gigs and see what I come up with, but my
>first impression is very positive.
>
>Cheers,
>Mark
>
>
>
>-------------------------------------------------------
>The SF.Net email is sponsored by EclipseCon 2004
>Premiere Conference on Open Tools Development and Integration
>See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
>http://www.eclipsecon.org/osdn
>_______________________________________________
>Linuxsampler-devel mailing list
>Lin...@li...
>https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
>
>  
>