Re: [Linuxsampler-devel] LinuxSampler BUGS to fix (Christian & others)

[<be...@ga...>]

Scrive Christian Schoenebeck <chr...@ep...>:

> Es geschah am Montag, 17. November 2003 12:40 als be...@ga... schrieb:
> > Download the latest CVS where Christian made some fixes that avoid
> > crashes and apply the above change.
> 
> There is still at least one nasty bug, I will have a look at it when I have 
> the time for it again (next couple of days).

Yes, 
for example if I do the following: load the compressed piano GIG,
press sustain and eat up all polyphony (64) until you get no free voice
messages.
Then let the voices decay till the samples end. 
Now start to hit keys again (with and without sustain pressed) and you
will notice several streams will remain active even when no voices are
played.
At this point you get lots of "disktstream not ready in time" messages.

Christian any idea what could cause this ?
I'm a bit busy this week so I cannot perform extensive debugging sessions.
Anyway the new ReleaseVoice() code looks fine (pVoiceSelf etc), 
good job Christian !

> 
> > Anyway LS currently uses a method to stream crompressed .GIG files which
> > is a bit suboptimal. Basically no caching of the decompressed stream is
> > performed so the decompressing is performed all the time (in the
> > low priority disk thread).
> > Anyway I'm unsure if caching would buy us anything because those samples
> > are so large that you could only cache small parts and playing dynamic
> > pieces you trigger a large number of the samples contained in the GIG so I
> > guess caching would be only a big coding work with maybe gaining only a
> few
> > % in terms of absolute performance.
> 
> It wouldn't be a good idea at all to cache it, and the decompression
> algorithm 
> is already quite optimal at least in the aspect that it's pure C++. Low level
> 
> optimization would make sense here, but that has to wait until the more 
> important things are done. Keep in mind: how many compressed gigs are out 
> there? Not many...

I agree on all the above, this is why I already said that the current
method we use is perfectly fine.

Christian any idea why on Mark's box the current CVS does not work ?
Mark can you elaborate ?


cheers,
Benno
http://www.linuxsampler.org


-------------------------------------------------
This mail sent through http://www.gardena.net