From: Ross M. <mrr...@gm...> - 2023-09-28 11:45:10
|
---------- Forwarded message --------- From: Ross Maxx <mrr...@gm...> Date: Thu, Sep 28, 2023 at 1:41 PM Subject: Some patches to libgig. To: <cu...@us...> Hi from the LMMS team. I am a contributor there. We use libgig for our gig player plugin, which plays .gig files. I, along with some other devs, were working on getting gigplayer ported to MSVC and came to know that libgig is not there in vcpkg. So I opened a PR there to get it added. Here's the Pull Request link : [libgig] New Port by Rossmaxx · Pull Request #33255 · microsoft/vcpkg (github.com) <https://github.com/microsoft/vcpkg/pull/33255> While working with the port, we patched some stuff temporarily and would like to upstream some of those patches. patch 1 - fix ssize_t on MSVC. MSVC compiler doesn't contain `ssize_t` but it contains `SSIZE_T`. patch 2 - set minimum C++ 11 in Cmake. Missing condition, should be there. patch 3 - fix usage of libakai. There was an issue with cmake in libakai Hope you get back to me soon. (I originally sent this mail to Christian, who told me to forward this to the mailing list.) |