Re: [Linuxsampler-devel] gigedit crashes when creating ne gig-file. pango/gtkmm3?

[Christian S. <sch...@li...>]

On Freitag, 12. November 2021 12:17:16 CET Kolja Koch wrote:
> > Which makes me wonder why I don't get these GTK compiler errors with the
> > same gtk(mm) 3.24.5 version. Are you sure you are compiling against the
> > header files of exactly *that* gtk version and not probably against
> > header files of gtk(mm) 4.x? Because gtk4 is not supported, gtk2 and gtk3
> > are though.
> Looks like gtkmm-3.0 to me:
> 
> configure:20453: g++ -std=gnu++11 -c -g -O2 -I/usr/include/gtkmm-3.0
> -I/usr/lib/gtkmm-3.0/include -I/usr/include/giomm-2.4
> -I/usr/lib/giomm-2.4/include -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid
> -I/usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include
> -I/usr/include/sigc++-2.0 -I/usr/lib/sigc++-2.0/include
> -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz
> -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/fribidi
> -I/usr/include/cairo -I/usr/include/lzo -I/usr/include/pixman-1
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0
> -I/usr/include/cloudproviders -I/usr/include/atk-1.0
> -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0
> -I/usr/lib/dbus-1.0/include -I/usr/include/at-spi-2.0
> -I/usr/include/cairomm-1.0 -I/usr/lib/cairomm-1.0/include
> -I/usr/include/pangomm-1.4 -I/usr/lib/pangomm-1.4/include
> -I/usr/include/atkmm-1.6 -I/usr/lib/atkmm-1.6/include
> -I/usr/include/gtk-3.0/unix-print -I/usr/include/gdkmm-3.0
> -I/usr/lib/gdkmm-3.0/include -pthread   conftest.cpp >&5
> 
> 
> GTKMM_LIBS='-lgtkmm-3.0 -latkmm-1.6 -lgdkmm-3.0 -lgiomm-2.4 -lgtk-3 -lgdk-3
> -lz -latk-1.0 -lcairo-gobject -lgio-2.0 -lpangomm-1.4 -lglibmm-2.4
> -lcairomm-1.0 -lsigc-2.0 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -lcairo
> -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 '
> 
> GTK_CFLAGS='-I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz
> -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount
> -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo
> -I/usr/include/lzo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0
> -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders
> -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0
> -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include
> -I/usr/include/at-spi-2.0 -pthread '
> 
> Or am I missing something?
> I'm a little bit confused that it states gtkmm-3.0, although my
> package-management states gtkmm3 version 3.24.5-2

Ok, that's probably fine, i.e. it was presumably Gtk 3.24.5 as you said 
before. It is normal for the gtkmm header files being placed into a "gktm-3.0" 
directory. That seems to be consistent among distros.

> > What compiler and compiler version (see config.log file)?
> 
> g++ (GCC) 11.1.0

Ok, then probably not an issue in this case, but good to know.

> > > I managed to install gigedit by applying two patches:
> > > 
> > > gigedit-1.2.0-libdir.patch
> > > gigedit-1.2.0-redeclare.patch
> > > 
> > > but have no clue, what exactly it is they're doing....
> > 
> > Me neither. You are only posting patch names, but not the URL where you
> > got
> > them from.
> 
> Since installing gigedit-svn from archlinux' AUR didn't work, I looked into
> the PKGBUILD of the 'official' package 
> https://archlinux.org/packages/community/x86_64/gigedit/
> Here's the link to the corresponding github-directory including the patches:
> https://github.com/archlinux/svntogit-community/tree/packages/gigedit/trunk
> 
> The PKGBUILD states:
> 
> # install shared object to global namespace, so no ld.so.conf is required
> patch -Np1 -i ../"${pkgname}-1.2.0-libdir.patch"
> # do not extend the pango namespace (breaks the build)
> patch -Np1 -i ../"${pkgname}-1.2.0-redeclare.patch"

So gigedit-1.2.0-libdir.patch just changes the installation directory for 
gigedit. Some distros want to have certain libs installed like this:

	/usr/lib/libname-version/*.so

and others like this:

	/usr/lib/*.so

And that patch changes it to the latter. Should not be an issue.

The other patch gigedit-1.2.0-redeclare.patch tries to address the compilation 
error that you get, but it does not really do that correctly. It should rather 
be addressed in compat.h here instead:

#ifndef HAS_PANGOMM_CPP11_ENUMS
   // new enums introduced in unstable pangomm 2.41.3, but not in stable 2.42
# if PANGOMM_MAJOR_VERSION > 2 || (PANGOMM_MAJOR_VERSION == 2 && 
((PANGOMM_MINOR_VERSION == 41 && PANGOMM_MICRO_VERSION >= 3) || 
PANGOMM_MINOR_VERSION > 42))
#  define HAS_PANGOMM_CPP11_ENUMS 1
# else
#  define HAS_PANGOMM_CPP11_ENUMS 0
# endif
#endif

What is the exact pangomm version reported to be installed there? Because that 
pangomm version issue was indeed always a bit fishy. As you can see from the 
compat.h comment above, they had a weird version scheme (stable vs. unstable 
pangomm, new features branch vs. maintenance branch). So that's something I 
should fix here more cleanly on our side.

All those things are not likely being related with the crash you got though.

> > The CRC-32 checksum of each sample in a .gig file are generated/updated
> > only at the end of the .gig file saving process. So it is normal that new
> > samples first have a CRC initialized with ffffffff at first.
> 
> Ah, ok!

There is also "gigdump --verify foo.gig" from the command line BTW
(man gigdump).

> > > Are those issues related to each other?
> > > - My guess is no.
> > > Does anybody has an idea, what the root-cause might be?
> > 
> > As my telepathic abilities are just sub average, and my valueable crystal
> > ball has never been handed back to me, I fear you would need to provide
> > more info that a mortal person would be able to decode.
> 
> That's a shame! Maybe, you should have asked the crystal ball, before giving
> it away, if you will ever get it back? ;)

Yes, I clearly failed as a user.

> > You could start by providing the questioned info, plus a backtrace of the
> > crash.
> 
> I will try to gather some more information next week and follow up on this.
> Thanks and have a nice weekend!

Sure, thanks, have a good one!

CU
Christian