[Linuxsampler-devel] Fix for a typo in the SFZ engine that breaks fade-ins.

[Christian C. <ce...@ce...>]

Hi,

I was trying to get the "Slender Salamander" SFZ sound font working under
linuxsampler. This is a sound font that contains phase-aligned samples for
three different velocities and then cross-fades between them:

     https://sig-ex.com/2017/11/11/slender-salmander-grand-piano/

I noticed that the cross-fade was off when using this sound font with
linuxsampler, and eventually root-caused the problem to a typo in
src/engines/sfz.cpp, which resulted in fade-ins being broken because of a
crossed wire in the initialization of xfin_hivel. (It was getting set to
the value of xfin_lovel).

Here is a patch that fixes the problem for me:

=====
--- src/engines/sfz/sfz.cpp.orig 2020-08-30 13:57:01.454616965 -0700
+++ src/engines/sfz/sfz.cpp 2020-08-30 15:04:51.249334686 -0700
@@ -689,7 +689,7 @@
         definition->xfout_hikey = xfout_hikey;
         definition->xf_keycurve = xf_keycurve;
         definition->xfin_lovel = xfin_lovel;
-        definition->xfin_hivel = xfin_lovel;
+        definition->xfin_hivel = xfin_hivel;
         definition->xfout_lovel = xfout_lovel;
         definition->xfout_hivel = xfout_hivel;
         definition->xf_velcurve = xf_velcurve;
=====

Hope you'll find this patch useful and thanks to all the developers for
their work on linuxsampler!

     regards,

     Christian