Re: [Linuxsampler-devel] GSt3: 128 3gnm chunks

[Christian S. <sch...@li...>]

On Montag, 20. Januar 2020 02:26:04 CET Ivan Maguidhir wrote:
> Hi Christian
> 
> On 19/01/2020 21:20, Christian Schoenebeck wrote:
> > Hi Ivan,
> > 
> > I just realized now your patch probably does not what you wanted it to:
> > http://svn.linuxsampler.org/cgi-bin/viewvc.cgi/libgig/trunk/src/gig.cpp?
> > r1=3656&r2=3655&pathrev=3656
> > 
> > You see the problem?
> 
> Nothing jumped out at me straight away. The code calls SaveString for
> existing 3gnm chunks in the _3gnl list using their Chunk* as the ck
> parameter. When the end of the _3gnl list is reached SaveString is
> called, from that point onward, with NULL as the ck parameter resulting
> in new 3gnm chunks being created for those strings and appended to the
> _3gnl list. This should result in 128 3gnm chunks containing the empty
> string regardless of the number of groups in the file.
> Group::UpdateChunks should call SaveString with the group name set by
> the user, leaving the remaining 3gnm chunks set to the empty string.
> Sorry if I'm missing something obvious.

Ah, you're right! Saul goode, thanks!

CU
Christian