Re: [Linuxsampler-devel] Gigedit: Positive Gain

[Christian S. <sch...@li...>]

On Freitag, 13. Dezember 2019 18:13:00 CET Ivan Maguidhir wrote:
> On 13/12/2019 13:40, Christian Schoenebeck wrote:
> > Nice job! :)
> > 
> > Give me some time, I probably have to make some minor adjustments to your
> > patch.

Ok, I just committed 2 parts of your patch. I committed your 128 '3gnm' chunks 
patch unmodified:
http://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=3656

Regarding the '3dnm' and '3ddp' chunks: I moved that to UpdateChunks() since I 
found that the more appropriate place to be, and I assumed that these chunks 
are just required for GigaStudio >= v3, hence these are only added there and 
auto removed if user switches back to a previous gig format version:
http://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=3657

Then your changes to AddDimension(): I could not reproduce that issue and 
accordingly I haven't committed that part of your patch yet. In my tests, when 
I start with an Instrument with no dimension and then add another dimension I 
never ended up with duplicate RIFF chunks. Plus, as far as I can see it, your 
suggested changes would introduce other bugs, because e.g. you would be 
assigning the same DimensionRegion object several times to different 
'pDimensionRegions' array entries. So are you sure you still have issues with 
latest libgig SVN version that we would need to address here?

CU
Christian