|
From: Ivan M. <iv...@ma...> - 2019-02-20 18:04:06
|
On 20/02/2019 16:57, Christian Schoenebeck wrote: > Ok, I just committed the libgig changes for writing gig extension files (SVN > r3474). Please review and test them, because most nostably I do not have any > gigs with extension files so I cannot test it, and I am also missing some > knowledge about the new chunks (see below). No problem. I'll do this this evening. > Also note in DLS.cpp, where it is now automatically creating the 'doxf' chunk > if missing, I was assuming a chunk size of 148 bytes. Is that correct? Yes that's exactly right. 4 byte int containing '99', string zero padded to 128 bytes and 16 byte dlsid. > And I also figured out now what this ominous ".gx99" file is about: that's for > writing convolution effect data (a.k.a. GigaPulse). So now that makes more > sense why that is always handled separately as .gx99. That's great! I think this means that the string in the 'doxf' chunk might actually be an impulse name. I wonder also if the .gx99 file is just a RIFF file with a .gsi (Gigastudio Impulse) file embedded in it? I have several of both of these types of file to hand so I'll try to figure out if this is the case. It would be nice to know the .gsi file structure also in order to add reverb at some point in the future. > So I would suggest simply adding two checkboxes to gigedit's file format > dialog: > > - "Large File Support" (default on) > - "GigaStudio Legacy Extension Files" (default off) > That makes sense. I'll do that. > Thanks for your patch Ivan! You're more than welcome! > CU > Christian > All the best, Ivan |