Re: [Linuxsampler-devel] Sustain release velocity & Gigastudio 4

[Christian S. <sch...@li...>]

On Donnerstag, 20. Dezember 2018 11:38:04 CET Christian Schoenebeck wrote:
> On Donnerstag, 20. Dezember 2018 00:10:00 CET Ivan Maguidhir wrote:
> > I've attached an updated version of the linuxsampler-2.1.0.svn1 patch I
> > submitted on Tuesday morning.
> > The previous one should have worked most of the time but the logic
> > wasn't quite correct. I'm using copies of Tascam GigaPiano II, edited in
> > gigedit, to test my changes btw and they appear to be working.
> 
> I probably have to adjust your changes a bit. I will do so in the next
> couple days.

Ok, I committed changes against libgig and LS for this sustain pedal up issue. 
This time I took a different approach of what you orginally suggested with 
your patches.

On libgig side my intention was to only use one subchunk ("LSDE") for all 
format extensions that we might introduce on DimensionRegion level.

On LS side I had to use a more complex solution, that's because your runtime 
check against active voice objects would have its limitations, e.g. when the 
regular voice already came to its end (e.g. short sample) then no release 
trigger sample would have been triggered since the voice object was gone 
already.

As a side effect of that implementation on LS side, there is now actually 
already a code in place for allowing the complete opposite: playing release 
trigger samples only on sustain pedal up, but not on note-off. So i wonder 
whether I should add that somewhat exotic option to libgig as well?

CU
Christian