|
From: Ivan M. <iv...@ma...> - 2018-12-18 03:32:08
|
Hi Christian and everyone On 14/12/2018 12:08, Christian Schoenebeck wrote: > Well, that already a great step! Most of our valueable GSt infos we got were > by using the GSt instrument editor. > > However when the limit is still 2000 then I don't understand why you got the > sample offset problem at first place. When you look into config.h you will see > that the default value for precaching samples is 32768, so even if you have > samples there with 2000 start offsest, you should not get into any problems. I'd like to see how that Sonivox Synth instrument looks and behaves in GSEdit4 and GStudio4. That might provide some clues. I'll do that as soon as I can. > I would probably first implement it as optional dimension region option in > libgig and add a combo box for that in gigedit on dimension region level as > well. Find attached a few patches with an implementation of this. The option can only be modified at instrument level in gigedit, but gets populated down into the DimensionRegions of the instrument during saving, where it is easily accessible by linuxsampler, and vice versa during loading. I didn't implement half-pedaling because I'm not sure that the release samples should be played until the sustain pedal is fully released, I can change this easily though. I also included some work towards supporting writing of multi-part gig files and a small fix in gigedit where a pointer to a std::vector on the stack was being used by a ChoiceEntry widget after it had gone out of scope. I will continue working on the multi-part gig file writing as I would really like to be able to edit my PMI pianos in gigedit. > Then later on one could still add a NKSP script function allowing to override > the behaviour by script. Keep in mind most users are no software developers. > So writing a NKSP script is often beyond their abilities. You are right. The gigedit way is preferable. > CU > Christian All the best, Ivan |