Re: [Linuxsampler-devel] Sustain release velocity & Gigastudio 4

[Ivan M. <iv...@ma...>]

Hi Christian

On 10/12/2018 14:53, Christian Schoenebeck wrote:
> On Sonntag, 9. Dezember 2018 19:39:23 CET Ivan Maguidhir wrote:
>>> That makes sense. What does gigdump print as global file information for a
>>> gig v4 file?
>> Here's a link to a zip file containing dumps of all the GSt4 instruments
>> mentioned.
> I applied your libgig patch to SVN and added gig::File::VERSION_4 as new
> version identifier according to your dumps. Thanks!
>
> I also added a new option to gigedit File->Properties->File Format so that one
> could explicitly store with gig v4 file format. That might help when toying
> around with new gig v4 features.
>
Many thanks for doing this and for the mention on the website.
>> Find attached a patch that
>> prevents the crash by dropping notes. I didn't submit this yesterday as
>> it's a bit of a hack and I'm not sure if it's correct. The SONiVOX Synth
>> Pads.gig instrument still doesn't produce the sounds it's supposed to
>> with this patch. I will try to investigate how GSt4 handles this
>> instrument if I can get it running in a VM.
> The patch prevents the crash, that's correct, but the root cause seems to be
> that your gig file uses a higher sample playback start position than previously
> max. allowed and expected by the engine. So obviously even with the patch you
> won't be able to play the instrument correctly.
>
> Probably they raised that playback start position limit in v4. Since you are
> one of the very few people still having a working GSt 4 installation, that
> might also be valueable to see what maximum playback start position is allowed
> in the GSt 4 instrument editor.
>
> Once we know the max. playback start position in GSt Instr. Editor 4 we can
> raise that limit on LS side and that would resolve that issue correctly.
I haven't been able to get GSt4 working in a VirtualBox VM with the USB 
licenser passed through from the host so far :-( I'll keep working on 
this to find a solution. I might be able to find out the max start 
position by looking at the instrument editor in a debugger, I'll give 
this a try later today.
>>> Have you compared this behaviour with your GigaStudio 4 software there? Is
>>> that what GSt4 does when releasing the sustain pedal? So for instance if
>>> you press sustain down, then trigger a key with high velocity, then a 2nd
>>> time the same key with low velocity, then release the sustain pedal,
>>> would GSt then play a soft release trigger voice?
>> Not yet. It's actually years since I've used GSt4. I'm going to try and
>> get it working in a Windows XP VM this evening. I wrote a piece of
>> software several years ago for sending MIDI from JACK on Linux to a
>> driver running in a Windows VM over Ethernet. I hope I can find it
>> again. Using this I should be able to test the sustain pedal behaviour.
> Interesting! Might be a useful piece of software for other people as well. :-)
I should finish it off and publish it. I gave up on it because I could 
never get the audio over Ethernet part of it working. The idea was to be 
enable the use VSTs etc. running on Windows in Linux programs like Ardour.
>
> I wait a bit before applying your sustain patch to LS. Let's see what test
> results you get there with GSt 4 on this issue.

I didn't specify it in earlier emails but the the Sustain Release issue 
applies to GSt3 also. In fact the instrument I mentioned, PMI Emperor, 
is actually a GSt3 instrument. As I couldn't get GSt4 working I set up a 
VM running GSt3 this morning. I recorded a MIDI file on my Linux host 
containing a loud note followed by a soft note with the sustain pedal 
pressed followed by the release of the sustain pedal, as you suggested. 
When this file is played through LinuxSampler with my patch applied I 
hear the notes followed by the sustain release samples played at the 
velocity of the last note. When the file is played through GSt3 I hear 
no sustain release samples at all. So it would seem that neither the 
current behaviour nor the behaviour with my patch applied are correct. I 
think the sustain release behaviour changed from version 1.0 here 
http://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=2927

> Thanks!
>
> CU
> Christian

All the best,
Ivan

>
>
> _______________________________________________
> Linuxsampler-devel mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel