|
From: Rui N. C. <rn...@rn...> - 2004-11-25 11:00:10
Attachments:
libgig-0.7.2-0.patch.gz
|
Hi Chris, everyone, (I'm re-posting this as I didn't got anything back from linuxsampler-devel list to date; just lag or has it gone the drain of some spam blackhole? sorry for th einconvenience) While integrating libgig support into QSampler I've detected a minor quirk in the "gig.h" header file, that has been solved by simply inserting a oneliner: a forward declaration of gig::Region class. Apparentely, a compiler error was just exposed if you include "gig.h" under a Qt C++ project (as is qsampler), and was all about "Region" being an already typedef'd symbol. This all comes to the attached patch, which also applies for correcting some other minor documentation install problems (man pages and doxygen docs). If nothing or no one goes against this, I'll be ready to commit into CVS soon. Oh, this patch also applies for bumping up the libgig package version to 0.7.2. Please check it out carefully, and tell me if you agree. Hope so. Cheers. -- rncbc aka Rui Nuno Capela rn...@rn... |
|
From: Christian S. <sch...@so...> - 2004-11-25 12:23:15
|
Es geschah am Donnerstag 25 November 2004 11:59 als Rui Nuno Capela schrieb: > This all comes to the attached patch, which also applies for correcting > some other minor documentation install problems (man pages and doxygen > docs). I wanted to fix the doxygen issue a while ago, thanks! But what's the reason for this man change? diff -duPNr libgig-0.7.1-0/man/Makefile.am libgig-0.7.2-0/man/Makefile.am --- libgig-0.7.1-0/man/Makefile.am 2004-07-07 13:03:54.000000000 +0100 +++ libgig-0.7.2-0/man/Makefile.am 2004-11-24 12:57:40.431283288 +0000 @@ -1,7 +1,7 @@ ## Process this file with automake to produce Makefile.in # all man files that should be installed -man1_MANS = dlsdump.1 gigdump.1 gigextract.1 rifftree.1 +man_MANS = dlsdump.1 gigdump.1 gigextract.1 rifftree.1 > If nothing or no one goes against this, I'll be ready to commit into CVS > soon. > > Oh, this patch also applies for bumping up the libgig package version to > 0.7.2. Please check it out carefully, and tell me if you agree. How urgent is this? My plan was to package the next release of libgig parallel to the release of LS and bumb the version to 1.0.0 to continue with libtool versioning scheme from that on. So can this wait for one or two weeks? If yes please just commit the changes and leave the version unchanged so far. I also have to change some tiny things in Debian packaging. CU Christian |
|
From: Rui N. C. <rn...@rn...> - 2004-11-25 12:54:05
|
Hi Christian, >> This all comes to the attached patch, which also applies for correcting >> some other minor documentation install problems (man pages and doxygen >> docs). > > I wanted to fix the doxygen issue a while ago, thanks! But what's the > reason for this man change? > > diff -duPNr libgig-0.7.1-0/man/Makefile.am libgig-0.7.2-0/man/Makefile.am > --- libgig-0.7.1-0/man/Makefile.am 2004-07-07 13:03:54.000000000 +0100 > +++ libgig-0.7.2-0/man/Makefile.am 2004-11-24 12:57:40.431283288 +0000 > @@ -1,7 +1,7 @@ > ## Process this file with automake to produce Makefile.in > > # all man files that should be installed > -man1_MANS = dlsdump.1 gigdump.1 gigextract.1 rifftree.1 > +man_MANS = dlsdump.1 gigdump.1 gigextract.1 rifftree.1 > On all of the autotools installations I have around (Mdk 10.1, SUSE 9.2 and FC1) the man pages weren't being installed at all. As it seemed, if man_MANS is not set, automake just don't generate any actual make install rules. Go figure, it's the same autocrapola as usual ;) >> If nothing or no one goes against this, I'll be ready to commit into CVS >> soon. >> >> Oh, this patch also applies for bumping up the libgig package version to >> 0.7.2. Please check it out carefully, and tell me if you agree. > > How urgent is this? My plan was to package the next release of libgig > parallel to the release of LS and bumb the version to 1.0.0 to continue > with libtool versioning scheme from that on. So can this wait for one or > two weeks? If yes please just commit the changes and leave the version > unchanged so far. I also have to change some tiny things in Debian > packaging. > Not higly urgent, but by bumping up the version number I can get better track of my own RPM packaging. Notice that the oneliner gig.h change is an issue as for building qsampler from source, so youl better be sure you have libgig-devel-0.7.2 installed and not libgig-devel-0.7.1. I shall not touch the libtool versioning (0:0:0), so I think my proposed version bump is just an interim and janitoral tagging measure. I can see no harm in it, but you're the boss :) -- rncbc aka Rui Nuno Capela rn...@rn... |
|
From: Christian S. <sch...@so...> - 2004-11-25 19:06:51
|
Es geschah am Donnerstag 25 November 2004 13:52 als Rui Nuno Capela schrieb: > On all of the autotools installations I have around (Mdk 10.1, SUSE 9.2 > and FC1) the man pages weren't being installed at all. > > As it seemed, if man_MANS is not set, automake just don't generate any > actual make install rules. Go figure, it's the same autocrapola as usual > ;) Strange, it worked fine on Debian Woody, Sarge and Sid. > Not higly urgent, but by bumping up the version number I can get better > track of my own RPM packaging. Notice that the oneliner gig.h change is an > issue as for building qsampler from source, so youl better be sure you > have libgig-devel-0.7.2 installed and not libgig-devel-0.7.1. Well, if qsampler doesn't build that's really an issue. Then I propose you commit your patch, leaving the version untouched and I promise I will do the Debian specific changes tomorrow, so we can fire out the 1.0.0 release tomorrow. It wouldn't make sense to make two releasese in few days, just because of my tiny Debian packaging changes. CU Christian |
|
From: Rui N. C. <rn...@rn...> - 2004-11-27 12:18:13
|
Hi,
Heads up. This is about to note that I have those libgig 1.0.0 packages
ready and available from the following urls:
My personal homeserver:
http://www.rncbc.org/ls/
Qsampler sourceforge.net project page:
http://sourceforge.net/projects/qsampler
I've made a standard release source tarball, libgig-1.0.0.tar.gz (packaged
via 'make dist') and a gang of RPMs for SUSE 9.2, Mandrake 10.1 and Fedora
core 1. RPMs are x86 only.
Enjoy,
--
rncbc aka Rui Nuno Capela
rn...@rn...
|