Re: [Linuxptp-devel] [PATCH v3 6/6] Add example Common Mean Link Delay Service configuration files.

[Richard C. <ric...@gm...>]

On Tue, Dec 05, 2023 at 02:44:18AM +0100, Andrew Zaborowski wrote:

>  * if I stop a CMLDS client and rerun it, it will receive the CMLDS
> notifications twice until the old subscription expires.  If I restart
> it again quickly enough it'll receive each notification 3 times.  This
> is because pmc_recv doesn't filter by .targetPortIdentity.  It could
> but it wouldn't be bullet proof anyway because the PMC port's identity
> is based on the pid, which is not unique, so I'm not sure if it's
> worth doing.

Yeah, super annoying.  Maybe the cure is to first cancel push
notifications unconditionally?
 
>  * inhibit_delay_req / logMinPdelayReqInterval /
> operLogPdelayReqInterval should not be used in the CMLDS client config
> (which wouldn't be useful anyway) because they'll affect the
> subscription renewals.

Right, a check should be added to avoid this combination.
 
>  * I had two extra changes, one to always calculate the NRR in the
> CMLDS port,

Can't this be taken from the Link Port?

Thanks,
Richard