Re: [Linuxptp-devel] [PATCH v3 5/6] Implement the COMMON_P2P delay mechanism.

[Miroslav L. <mli...@re...>]

On Sat, Dec 02, 2023 at 03:38:18PM -0800, Richard Cochran wrote:
> --- a/config.c
> +++ b/config.c
> @@ -171,6 +171,7 @@ static struct config_enum delay_filter_enu[] = {
>  
>  static struct config_enum delay_mech_enu[] = {
>  	{ "Auto", DM_AUTO },
> +	{ "COMMON_P2P", DM_COMMON_P2P },

The new option is missing in the ptp4l usage text.

>  	{ "E2E",  DM_E2E },
>  	{ "P2P",  DM_P2P },
>  	{ "NONE", DM_NO_MECHANISM },
> @@ -249,6 +250,11 @@ struct config_item config_tab[] = {
>  	GLOB_ITEM_INT("clock_class_threshold", CLOCK_CLASS_THRESHOLD_DEFAULT, 6, CLOCK_CLASS_THRESHOLD_DEFAULT),
>  	GLOB_ITEM_ENU("clock_servo", CLOCK_SERVO_PI, clock_servo_enu),
>  	GLOB_ITEM_ENU("clock_type", CLOCK_TYPE_ORDINARY, clock_type_enu),
> +	PORT_ITEM_STR("cmlds.client_address", "/var/run/cmlds_cleint"),

Swapped e and i in "cleint" is not intentional, right? It's the same
in the man page and the example default config.

Other than that, the patchset looks ok to me. I didn't run any tests,
just a quick look at the code. I'll update the pmc test in the
testsuite.

-- 
Miroslav Lichvar