Re: [Linuxptp-devel] [PATCH] Add scaledLastGmFreqChange computation

[Erez <ere...@gm...>]

On Sun, 26 Nov 2023 at 22:07, Richard Cochran <ric...@gm...>
wrote:

> On Thu, Nov 23, 2023 at 01:39:45PM +0100, Erez wrote:
> > On Thu, 23 Nov 2023 at 04:26, Chwee-Lin Choong <
> chw...@in...>
> > wrote:
> >
> > > Add the computation for scaledLastGmFreqChange, as specified in
> > > IEEE 802.1AS-2020, clause 11.4.4.3.9. This incorporates the
> > > necessary logic to calculate scaledLastGmFreqChange and
> > > appends the result to the follow-up TLV.
> > >
> > > In addition, a naming error has been rectified from
> > > scaledLastGmPhaseChange to scaledLastGmFreqChange.
> > >
> >
> > It might be an error, but we do not change a public API.
> > As some users might depend on it.
>
> No, this does not break an API/ABI.  The name of a field in a header
> file is a C language identifier, and it does not exist at run time.
>
> (Changing the size, type, or position of a field, now THAT would break
> the ABI)
>

It is public if you change the printed name in PMC.

Erez


>
> Thanks,
> Richard
>
>