Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

[Richard C. <ric...@gm...>]

On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote:

> @@ -651,6 +652,18 @@ static void pmc_show(struct ptp_message *msg, FILE *fp)
>  		fprintf(fp, "LOG_MIN_PDELAY_REQ_INTERVAL "
>  			IFMT "logMinPdelayReqInterval %hhd", mtd->val);
>  		break;
> +	case MID_CMLDS_INFO_NP:
> +		cmlds = (struct cmlds_info_np *) mgt->data;
> +		fprintf(fp, "CMLDS INFO "
> +			IFMT "serviceMeasurementValid %i"
> +			IFMT "meanLinkDelay %" PRId64
> +			IFMT "scaledNeighborRateRatio %" PRId32
> +			IFMT "egress_ts %" PRId64
> +			IFMT "rx_ts %" PRId64,
> +			cmlds->serviceMeasurementValid, cmlds->meanLinkDelay,
> +			cmlds->scaledNeighborRateRatio,
> +			cmlds->egress_ts, cmlds->rx_ts);
> +		break;

Nit: please place this after MID_POWER_PROFILE_SETTINGS_NP
rather than tacking on the end of the switch/case.

Thanks,
Richard