Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

[Richard C. <ric...@gm...>]

On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote:

> @@ -473,6 +476,14 @@ struct msg_interface_rate_tlv {
>         UInteger16    numberOfBitsAfterTimestamp;
>  } PACKED;
>  
> +struct cmlds_info_np {
> +	Integer8     serviceMeasurementValid;
> +	TimeInterval meanLinkDelay;
> +	Integer32    scaledNeighborRateRatio;
> +	Integer64    egress_ts;
> +	Integer64    rx_ts;
> +} PACKED;

This layout is very poor for packed formats -- think about alignment!

Please order the fields according to size, from largest to smallest.

Thanks,
Richard