Re: [Linuxptp-devel] [PATCH v4 00/11] Profile support for IEEE C37.238-2011 and IEEE C37.238-2017
PTP IEEE 1588 stack for Linux
Brought to you by:
rcochran
|
From: Miroslav L. <mli...@re...> - 2023-02-02 10:52:23
|
On Sat, Jan 28, 2023 at 02:43:41PM -0800, Richard Cochran wrote: > The Power Profile specifies two new TLVs: It would be nice to have the new options documented in the ptp4l man page. Please consider renaming tztool to something more PTP-specific, (maybe tz2ptp4l?), to not confuse people that is does something with the system tz database. Other than that and the issues I pointed out in the other mail, the patches look good to me. I have no devices that support the power profile. I juts ran few tests and it seemed to work as expected. Wireshark prints the new TLV. No issues seen with valgrind and address sanitizer. -- Miroslav Lichvar |