Re: [Linuxptp-devel] [PATCH v4 11/11] Introduce a time zone helper program.

[Miroslav L. <mli...@re...>]

On Sat, Jan 28, 2023 at 02:43:52PM -0800, Richard Cochran wrote:
> +++ b/makefile
> @@ -22,7 +22,7 @@ CC	= $(CROSS_COMPILE)gcc
>  VER     = -DVER=$(version)
>  CFLAGS	= -Wall $(VER) $(incdefs) $(DEBUG) $(EXTRA_CFLAGS)
>  LDLIBS	= -lm -lrt -pthread $(EXTRA_LDFLAGS)
> -PRG	= ptp4l hwstamp_ctl nsm phc2sys phc_ctl pmc timemaster ts2phc
> +PRG	= ptp4l hwstamp_ctl nsm phc2sys phc_ctl pmc timemaster ts2phc tztool

The new program doesn't have a man page and is listed here last,
which causes "make install" to fail. That "[ -f $$x ]" in the install
recipe needs to be followed by something returning zero, e.g. ":".

> +++ b/tztool.c

> +static int update_ptp_serivce(struct tzinfo *tz, struct tzinfo *next)

Typo in the function name   ^^.

> +	if (next) {
> +		atop.jumpSeconds = next->local_tai_offset - tz->local_tai_offset;
> +		atop.timeOfNextJump.seconds_lsb = next->timestamp;
> +	}

Is this intentionally not setting the _msb field, ignoring distant future?

-- 
Miroslav Lichvar