Re: [Linuxptp-devel] [PATCH v4] Strip PRP trailer
PTP IEEE 1588 stack for Linux
Brought to you by:
rcochran
From: Richard C. <ric...@gm...> - 2022-08-08 13:59:35
|
On Mon, Aug 08, 2022 at 01:11:36PM +0200, Erez wrote: > On Mon, 8 Aug 2022 at 12:36, Miroslav Lichvar <mli...@re...> wrote: > > would be nice to convert them all avoid confusion. Yes, but not here with new code. > The question is not if other code uses it, but what is better. > Though the function name suggests boolean. > I think we should do both, to make code clearer and more readable. > It also makes the patch more coherent. Yeah, please have new code use Boolean type when functions are predicates (is_a, has_a, etc). (I used to avoid bool because of poor compilers back in the Bad Old Days) Thanks, Richard |