Re: [Linuxptp-devel] [PATCHv1 2/4] rtnl: Add function to detect virtual clocks.

[Richard C. <ric...@gm...>]

On Thu, Feb 10, 2022 at 11:57:40AM +0100, Miroslav Lichvar wrote:
> On Thu, Feb 03, 2022 at 11:36:12AM -0800, Richard Cochran wrote:
> > Nit: please prefix with rtnl_
> 
> Even when it is a static function? Most static functions in the
> codebase don't seems to have a matching prefix, so I'm unsure why
> this one.

You are right, of course, but as the code base grows it gets more and
more useful for grep/cscope.  So for new code, I'd like to have the
pendantic prefixes.

> In any case, would you like me to send a v2 now or should I wait for
> comments on the other patches from the series?

Looks good otherwise, please send v2.

Thanks,
Richard