Re: [Linuxptp-devel] [PATCHv1 2/4] rtnl: Add function to detect virtual clocks.

[Miroslav L. <mli...@re...>]

On Thu, Feb 03, 2022 at 11:36:12AM -0800, Richard Cochran wrote:
> On Thu, Feb 03, 2022 at 12:50:06PM +0100, Miroslav Lichvar wrote:
> > diff --git a/rtnl.c b/rtnl.c
> > @@ -465,3 +466,85 @@ no_info:
> >  	nl_close(fd);
> >  	return index;
> >  }
> > +
> > +static int search_vclocks(struct rtattr *attr, int phc_index)
> 
> Nit: please prefix with rtnl_

Even when it is a static function? Most static functions in the
codebase don't seems to have a matching prefix, so I'm unsure why
this one.

In any case, would you like me to send a v2 now or should I wait for
comments on the other patches from the series?

Thanks,

-- 
Miroslav Lichvar