Re: [Linuxptp-users] [Linuxptp-devel] Observing below issue with ptp4l running in BC mode

[Miroslav L. <mli...@re...>]

On Thu, Jan 20, 2022 at 06:11:57PM +0000, ramesh t via Linuxptp-users wrote:
> In clockcheck_sample function, we should depend on CLOCK_MONOTONIC to decide if its getting called more frequency than a second. But we also check on remote time:
> 
>         interval = (int64_t)ts - cc->last_ts;
>         if (interval >= 0 && interval < CHECK_MIN_INTERVAL)
>               return ret;
> 
> This may not be correct as remote phc time could have drifted. Hence when we call clockcheck_sample again mono_interval may be a higher value, resulting in variation of min and max freq_offset calculation.

The timestamp checked in the clockcheck code should always be a
timestamp of the clock synchronized by phc2sys, not the clock to which
it is synchronized (what I assume you mean by "remote"). Can you point
to the code path where this is not the case?

-- 
Miroslav Lichvar