Re: [Linuxptp-devel] [PATCH v2 2/3] clock: dump unexpected packets received on the error queues of
PTP IEEE 1588 stack for Linux
Brought to you by:
rcochran
From: Vladimir O. <ol...@gm...> - 2020-06-19 16:33:29
|
On Fri, 19 Jun 2020 at 18:47, Richard Cochran <ric...@gm...> wrote: > > On Fri, Jun 19, 2020 at 05:58:17PM +0300, Vladimir Oltean wrote: > > You need to recv() the data. Otherwise, it will remain forever there, > > ptp4l will be toast, since this will keep dispatching the fault ad > > infinitum. > > The fault handling path closes all sockets and opens new ones. > > Thanks, > Richard Then it is not correct to "continue" the loop, since it will keep iterating through the pollfd array for sockets that were closed in the meantime. And don't we want to set up a fault timer, to clear it eventually? -Vladimir |