Re: [Linuxptp-devel] [PATCH v2 1/3] ptp4l: call recvmsg() with the MSG_DONTWAIT flag

[Vladimir O. <ol...@gm...>]

On Fri, 19 Jun 2020 at 15:47, Richard Cochran <ric...@gm...> wrote:
>
> On Fri, Jun 19, 2020 at 03:41:09PM +0300, Vladimir Oltean wrote:
> > Ok, and this patch does not have a place in linuxptp because?
>
> It is a matter of style, as I already said.
>
> Thanks,

Again, I would have accepted any technical argument you could bring.
Like, for example, the fact that this sleep on recv() is becoming
impossible after patch "[PATCH v2 2/3] clock: dump unexpected packets
received on the error queues of sockets" (which _is_ fixing a ptp4l
application bug), even without MSG_DONTWAIT in place. But you prefer
to bring the style argument.
So, as a matter of personal style, I think the only right thing for me
to do is to retreat now. Feel free to use any portion of the patches I
submitted so far in any combination you see desirable.

Thanks,
-Vladimir