Re: [Linuxptp-devel] [PATCH v2 2/3] clock: dump unexpected packets received on the error queues of sockets

[Vladimir O. <ol...@gm...>]

On Fri, 19 Jun 2020 at 14:52, Richard Cochran <ric...@gm...> wrote:
>
> On Mon, Jun 15, 2020 at 06:23:20PM +0300, Vladimir Oltean wrote:
> > Printing them to the user is optional (and helpful), but reading them is
> > not. With this patch, even with extraneous data delivered by a buggy
> > kernel (which the application now loudly complains about), the
> > synchronization keeps chugging along. Otherwise the application starts
> > reordering packets in recvmsg() due to misinterpreting which socket
> > queue has data available.
>
> Again, I see this stack as production code and not a debugging tool.
> Hexdumping frames is more for wireshark or tools like
>
>    linux/tools/testing/selftests/net/[rx\|tx]timestamp
>
> in the kernel source.  In fact, I think that tool already dumps
> frames.
>
> Thanks,
> Richard

Sure. In fact, printing the data on the error queue is totally
optional and I could just as well remove it, no problem with that. But
reading it isn't. I don't think you've addressed that point.

-Vladimir