Re: [Linuxptp-devel] ptp4l wrongly takes padding bytes as TLV?

[Miroslav L. <mli...@re...>]

On Thu, Jan 31, 2019 at 04:28:30PM +0000, Vincent Li X wrote:
> But we still think it's more safe to use header.messageLength instead of
> socket count, 
> Msg.c
> 	err = suffix_post_recv(m, cnt - pdulen);
> ==>
> 	err = suffix_post_recv(m, m->header.messageLength - pdulen);

I'm not sure that is more safe. If the field had a large value, it
might enable reading of uninitialized data, possibly even past the
buffer. A better way is to check the length in each transport specific
code and either remove the padding or drop the packet if the transport
doesn't allow padding.

-- 
Miroslav Lichvar