[Linuxptp-devel] ptp4l wrongly takes padding bytes as TLV?

[Vincent Li X <vin...@er...>]

On Mon, Feb 19, 2018 at 05:59:23PM +0200, Yan Yankovskyi wrote:
> It seems now that VLAN driver isn't actually used in the system, and we
use
> a custom ethernet driver. This driver has skb_tx_timestamp(skb); call in
> it's start_xmit() routine, and I implemented and registered get_ts_info()
> function for ethtool. The interface now successfully passes ethtool check,
> and as far as I understand there are timestamps in ethernet frames. The
> only messages that don't contain timestamps are Announce messages, I guess
> it is not important?

Right.  Those are not event messages and don't get a time stamp.

> But I still got the problem: in suffix_post_recv() function call for Sync
> messages (cnt = 50, pdulen = 44) I'm getting wrong tlv values (always 0
for
> type, but some arbitrary values for length, e.g. 50666, 18066). Do you
have
> any idea what may go wrong? I don't understand is it some problems in our
> driver, or in ptp4l.

It is in your driver.  Sync messages never have TLVs attached.
Probably the packet length is too long.

HTH,
Richard

----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Lin...@li...
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel