[Linuxptp-devel] [PATCH v3 2/7] clock: Add NULL check for best clock in clock_update_slave()

[Vedang P. <ved...@in...>]

This scenario will only be encountered when the clock transitions to the
slave state without knowing who the master is.

This will result in a segfault for BMCA with designated master and slave
states (to be added in upcoming patches).

Signed-off-by: Vedang Patel <ved...@in...>
---
 clock.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/clock.c b/clock.c
index 0a000b958821..56bc79bf3454 100644
--- a/clock.c
+++ b/clock.c
@@ -636,7 +636,12 @@ static void clock_update_grandmaster(struct clock *c)
 static void clock_update_slave(struct clock *c)
 {
 	struct parentDS *pds = &c->dad.pds;
-	struct ptp_message *msg        = TAILQ_FIRST(&c->best->messages);
+	struct ptp_message *msg;
+
+	if (!c->best)
+		return;
+
+	msg                            = TAILQ_FIRST(&c->best->messages);
 	c->cur.stepsRemoved            = 1 + c->best->dataset.stepsRemoved;
 	pds->parentPortIdentity        = c->best->dataset.sender;
 	pds->grandmasterIdentity       = msg->announce.grandmasterIdentity;
-- 
2.7.3