[Linuxptp-devel] [RFC v2 0/5] Adding support for AVnu Automotive Profile

[Vedang P. <ved...@in...>]

Changes in V2:
~~~~~~~~~~~

Instead of using a single option (avnu_ap) which makes multiple changes to
linuxptp, we are taking a more granular approach by adding multiple config
options and a FSM to do the same thing. The highlights are the following:

- The first patch is just a small fix to msg_source_equal(). 
- The second patch introduce BMCA config option to select the static role FSMs
  to skip BMCA.
- The third patch introduces the inhibit_announce config option which disables
  announce messages on master and announce message timeouts on slaves.
- The fourth patch introduces the config option to disable the source port
  identity checks done on the Slave.
- The last patch adds an example configuration for the AVnu Automotive Profile.
- In all the series adds functionality from Sections 6.2.1.1 and Section 6.3
  (pts #1 and #2) of the AVnu Automotive Profile[1].

For further information, you can look at the cover-letter from the first version at:
https://sourceforge.net/p/linuxptp/mailman/message/36369408/

Some Opens: 
- Currently, we are using masterOnly (a per-port config option) and slaveOnly
  (a global config option) to determine role of the devices. This configuration
  option might be a little confusing to a new comer. One idea is to change
  slaveOnly to per-port config option. Are there any other ideas for this or
  the current way is not as confusing as I think?
- In port_p2p_transition(), we are setting up the delay timer when BMCA is set
  as ‘noop’. Usually it is initialized then the device transitions to
  PS_LISTENING. But, we are skipping the LISTENING state. Another alternative
  is to transition to PS_LISTENING and then unconditionally transfer to
  PS_MASTER/PS_SLAVE. But, that seems more of an hack than what is currently
  being done. Any other alternatives?
- Is there a place where I can add tests relating to the new features I added?
  What about https://github.com/mlichvar/linuxptp-testsuite?

Thanks,
Vedang Patel

[1] Automotive Ethernet AVB Functional and Interoperability Specification -
http://avnu.org/wp-content/uploads/2014/05/
Automotive-Ethernet-AVB-Func-Interop-Spec-v1.5-Public.pdf

Vedang Patel (5):
  port.c: Add condition to check fc.
  Add BMCA config option.
  Add inhibit_announce config option.
  Add ignore_source_id config option.
  Add example configuration for AVnu Automotive Profile.

 bmc.c                   |  11 ++++++
 config.c                |   9 +++++
 configs/AVnu-master.cfg |  27 +++++++++++++
 configs/AVnu-slave.cfg  |  30 +++++++++++++++
 configs/default.cfg     |   3 ++
 fsm.c                   | 100 ++++++++++++++++++++++++++++++++++++++++++++++++
 fsm.h                   |  26 +++++++++++++
 port.c                  |  80 +++++++++++++++++++++++++++++++++-----
 port.h                  |   8 ++++
 port_private.h          |   3 ++
 ptp4l.8                 |  31 +++++++++++++--
 11 files changed, 314 insertions(+), 14 deletions(-)
 create mode 100644 configs/AVnu-master.cfg
 create mode 100644 configs/AVnu-slave.cfg

-- 
2.7.3