Re: [Linuxptp-devel] [RFC 1/1] Add avnu_ap to enable AVnu Automotive Profile
PTP IEEE 1588 stack for Linux
Brought to you by:
rcochran
From: Patel, V. <ved...@in...> - 2018-07-26 18:24:31
|
On Wed, 2018-07-25 at 17:37 -0700, Richard Cochran wrote: > On Wed, Jul 25, 2018 at 05:13:03PM +0000, Patel, Vedang wrote: > > > > In the description above, you mentioned that we should use > > masterOnly > > and slaveOnly. But, from the pseudo code, it seems like you just > > want > > to make decision based only on slaveOnly option. Which one do you > > prefer? > The code should require that one of these is set when BMCA == noop. > > > > > If we are just using a single option, I would prefer masterOnly > > since > > it is a per-port variable and extending support to bridges will be > > easy. > How about this? Leave slaveOnly global. When BMCA == noop then > check > port option masterOnly, then global slaveOnly, else fail. > > Later on, a bridge that has both port types can set slaveOnly as the > global default and configure masterOnly per port as needed. > Thanks for the inputs. I will send out the updated patches soon. -Vedang > Thanks, > Richard |