Re: [Linuxptp-devel] [PATCH RFC V2 08/11] port: Implement the NetSync Monitor protocol.

[Anders S. <and...@es...>]

>I appreciate your taking the effort to review the series.  However, in the future, please do not top-post!
>Instead, comment directly in-line, and trim the reply to remove any patch hunks that are not being commented upon.

Ok, I will comment inline in the future, sorry about that.

>> +static void extract_address(struct ptp_message *m, struct PortAddress
>> +*paddr) {
>> static int msg_current(struct ptp_message *m, struct timespec now)  {
>> static struct follow_up_info_tlv *follow_up_info_extract(struct
>> ptp_message *m)  {
>> +static int port_nsm_reply(struct port *p, struct ptp_message *m) {
>> static int process_delay_req(struct port *p, struct ptp_message *m)  {

>^^^ no idea where you got this from.

I got them all from PATCH RFC V2 08/11 sent to me by mail, just did copy and pasted on the top. If there is something that is mismatched with your implementation I cannot say.
Normally this probably have slipped since I´ve seen a mixture of the two implementations, with or without linebreak, but since you last week sent a patch with these coding style updates, I spotted it.

>> no line break on this:
>> +    memcpy(&extra->foot->lastsync, &last_sync,
>> +sizeof(extra->foot->lastsync));

Above lines in a single line would be shorter than some other lines above. Easier to read without line break.


Btw, I was just looking at this Netsync Monitoring myself and was surprised that you, the same week, implemented it. Got a question from Meinberg to implement it if I could/had time and I was planning to start the coding this week😊
I think the solution overall was nicely implemented. I will have a closer look at it when I can have all the changes infront of me and a can switch between all the files. I think that’s easier.

Sorry if there were some incorrect comments.

//
Anders