Re: [Linuxptp-devel] Forwarding management messages to UDS port
PTP IEEE 1588 stack for Linux
Brought to you by:
rcochran
|
From: Richard C. <ric...@gm...> - 2017-12-08 02:00:24
|
On Thu, Dec 07, 2017 at 10:13:07AM +0100, Miroslav Lichvar wrote: > The trouble is that forwarding() is called twice from > clock_forward_mgmt_msg(), once with the source port and then with the > destination port. So, if it returned 0 for p == uds->port and action > == REQUEST, requests from pmc would not be forwarded. Oh. > Should it pass NULL as a msg in the first call to avoid the action check? Maybe the check should go into clock_do_forward_mgmt() instead? That looks cleaner to me. Thanks, Richard |