Re: [Linuxptp-devel] [PATCHv3 10/10] phc2sys: update clock clkid and phc_index if device changed

[Hangbin L. <liu...@gm...>]

On Wed, Aug 16, 2017 at 09:32:11PM +0800, Hangbin Liu wrote:
> @@ -322,7 +366,7 @@ static void reconfigure(struct node *node)
>  
>  		if (c->new_state) {
>  			if (c->new_state == PS_MASTER)

Another issue here. When we run phc2sys in slave mode and phc index changed
(normal link down/up or bond fail over). we also need do clock_reinit(). Or we
will get error like

ioctl PTP_SYS_OFFSET: No such device

So the check should be
  			if (c->new_state == PS_MASTER || c->new_state == PS_SLAVE)

I will add this fix in new version patch set.

> -				clock_reinit(c);
> +				clock_reinit(node, c);
>  
>  			c->state = c->new_state;
>  			c->new_state = 0;

Thanks
Hangbin