Re: [Linuxptp-devel] [PATCHv2 6/9] clock: check required_modes before use new ts info

[Richard C. <ric...@gm...>]

On Sat, Jul 15, 2017 at 09:33:08PM +0800, Hangbin Liu wrote:
> diff --git a/clock.h b/clock.h
> index 49ecb76..18d7250 100644
> --- a/clock.h
> +++ b/clock.h
> @@ -73,6 +73,13 @@ UInteger8 clock_class(struct clock *c);
>  struct config *clock_config(struct clock *c);
>  
>  /**
> + * Obtains the required time stamping mode.
> + * @param c  The clock instance.
> + * @return   The value of required time stamping mode.

The comment should document that the returned value is a bit mask of
SOF_TIMESTAMPING_ flags.

> + */
> +int clock_required_modes(struct clock *c);

Thanks,
Richard