Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

[Keller, J. E <jac...@in...>]

> -----Original Message-----
> From: Richard Cochran [mailto:ric...@gm...]
> Sent: Wednesday, July 19, 2017 9:53 PM
> To: Keller, Jacob E <jac...@in...>
> Cc: Hangbin Liu <liu...@gm...>; Sushil Kulkarni
> <suk...@re...>; lin...@li...; Jiri Benc
> <jb...@re...>
> Subject: Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info
> 
> On Wed, Jul 19, 2017 at 08:47:43PM +0000, Keller, Jacob E wrote:
> > if (rtnl_link_query(fd, index))
> >     err = -1;
> > else if (rtnl_link_status(fd, NULL, iface->ts_iface))
> >     err = -1;
> 
> This is poor practice, because you clobber the code returned from
> the sub-routine that experienced the error.
> 
> Thanks,
> Richard

Correct. I like your proposed solution better. I was merely re-writing to show how the logic flow would work, and preserved the return code the original code had.

Thanks,
Jake