Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

[Richard C. <ric...@gm...>]

On Wed, Jul 19, 2017 at 08:47:43PM +0000, Keller, Jacob E wrote:
> if (rtnl_link_query(fd, index))
>     err = -1;
> else if (rtnl_link_status(fd, NULL, iface->ts_iface))
>     err = -1;

This is poor practice, because you clobber the code returned from
the sub-routine that experienced the error.

Thanks,
Richard