Re: [Linuxptp-users] ptp4l and network connectivity interruption
PTP IEEE 1588 stack for Linux
Brought to you by:
rcochran
From: Brian W. <br...@wa...> - 2015-12-12 20:48:15
|
On Sat, Dec 12, 2015 at 06:50:45PM +0100, Richard Cochran wrote: > This is definitely a driver bug. > > Looking at drivers/net/ethernet/intel/e1000e/netdev.c, in the function > e1000e_config_hwtstamp(), the time is reset whenever time stamping is > activated. That doesn't make any sense. > > It looks like the calls to e1000e_get_base_timinca() and > timecounter_init() are misplaced. They should go into the probe > function instead. I see that. Comparing that code to what happens in the ixgbe driver it looks like reseting the clock should be part of e1000e_ptp_init. Then the e1000e_ptp_init code should be called in the device open function to initialize whenever the device is made active. Pull ptp_init out of the probe function. I will see what i can put together to test based off of the ixgbe code. Brian |