Re: [Linuxptp-users] Missing Sanity Checks for malloc()/calloc()/strdup() in linuxptp-1.5
PTP IEEE 1588 stack for Linux
Brought to you by:
rcochran
From: Bill P. <wp...@gm...> - 2015-08-21 16:43:41
|
This was a manual review of the code, I did not use something like clang-analyzer to find these :) The wrapper approach makes sense as well (IMO). Bill On Fri, Aug 21, 2015 at 8:52 AM, Keller, Jacob E <jac...@in...> wrote: > On Fri, 2015-08-21 at 08:55 +0200, Miroslav Lichvar wrote: > > > I think an easier and cleaner approach would be to write wrappers for > > the strdup/calloc/malloc/realloc functions which just send an error > > message and call exit(1) when the allocation fails, and use the > > wrappers everywhere in the code. > > > > Yea, I think this is probably a good call. We could use these > everywhere in the code base. > > Regards, > Jake |