Re: [Linuxptp-devel] [PATCH] Force IPv6 to IPV6 only, no ipv4 to ipv6 mapping.

[Jiri B. <jb...@re...>]

On Mon, 10 Aug 2015 12:14:56 -0700, Gary E. Miller wrote:
> By default, at least on Linux, opening a PF_INET6 socket also
> grabs the matching IPv4 port.  This patch stops that.

Looks good but I think it should have more detailed description.
Especially elaborate on the reasons why linuxptp needs to
unconditionally deviate from the system-wide setting.

I always hate when I'm debugging a problem, track it down to a
particular commit and it's completely unclear why the change was
introduced. Given the confusion this option creates, I think that more
detailed description is in place here. Think about somebody who expects
that the v6 socket listens also for v4 traffic as he's used from other
programs and tries to debug why linuxptp behaves differently (I know
that you stated that's only minor part of users and you're probably
right but that's going to change once IPv6 becomes more common and
people get used to this behavior).

> Only tested on Linux.  Unknown how this will work on *BSD or WinXX.

I wouldn't worry about it given the amount of Linux-only interfaces
linuxptp uses.

Thanks,

 Jiri

-- 
Jiri Benc