Re: [Linuxptp-users] Problems with hardware time stamping with PHY DP83640 on MCP5200 powerpc platform

[Richard C. <ric...@gm...>]

On Wed, May 30, 2012 at 06:20:32PM +0200, Stephan Gatzka wrote:
> Hello Richard,
> 
> I'm a colleague of Mario and we found the reason for the strange
> data int the skb.
> 
> >Wow, that looks really wrong. I don't see a MAC address anywhere.
> >
> 
> The problem lies in the file
> linux/drivers/net/ethernet/freescale/fec_mpc52xx.c
> 
> In the receive interrupt function mpc52xx_fec_rx_interrupt
> the call to skb_defer_rx_timestamp is done using  a freshly
> allocated skb (called skb) and not with the received skb (called
> rskb). Calling skb_defer_rx_timestamp with the correct parameter
> engages  the whole engine.

Oops. I added that code. My bad.
 
> We would be happy to make a patch for this fix. Do you think the
> powerpc mailing list is more suitable than the linux-netdev?

Please post the fix to netdev, and add the tag for stable like this:

Cc: <st...@vg...> [affects 3.1 and newer]

Thanks,
Richard