[linuxdc-dev] drivers/net/8139too.c changes?

[Tom R. <tr...@ke...>]

Hi all.  In looking at the CVS 'linuxsh' sources against 2.6.8.1 I
noticed the following in drivers/net/8139too.c:
@@ -975,16 +975,23 @@ static int __devinit rtl8139_init_one (s
        if (i < 0)
                return i;

-       assert (dev != NULL);
        tp = dev->priv;
-       assert (tp != NULL);
        ioaddr = tp->mmio_addr;
+       
        assert (ioaddr != NULL);
+       assert (dev != NULL);
+       assert (tp != NULL);

But that seems wrong.  We want to make sure dev or tp aren't NULL before
poking around in them.

-- 
Tom Rini
http://gate.crashing.org/~trini/