From: Robert L. <rm...@te...> - 2001-12-06 06:49:20
|
In 2.4.15-pre7, the following change to include/asm-sh/string.h were merged: -#define __HAVE_ARCH_MEMSCAN -#define memscan memchr This was a Good Thing, since the two function are not specified to have the same behavior. memchr returns NULL on no match, and memscan returns addr+1 if a match is not found. The problem lies in that there is SH arch code that depended on the false behavior of memscan -- that is, even though they called memscan, they assumed it returned NULL on no match (since it was defined as memchr which does just that). At least one problem area was found: maple_keyb.c, and this was causing my previously reported keyboard problem on my Dreamcast. The attached patch fixes the problems. There may be more. _Please_ merge into CVS. Robert Love |