On Saturday 31 Aug 2002 11:30 pm, M. R. Brown wrote:
> * Adrian McMenamin <zx8...@us...> on Sat, Aug 31, 2002:
> > Update of /cvsroot/linuxdc/linux-sh-dc/drivers/mtd/maps
> > In directory usw-pr-cvs1:/tmp/cvs-serv23778/drivers/mtd/maps
> >
> > Modified Files:
> > vmu-flash.c
> > Log Message:
> > VMU reads now verified as working
>
> You may want to consider wrapping all those printk's in a CONFIG_VMU_DEBUG
> or some other kind of option. Unecessary printk's (esp. just status ones)
> are hazardous to your health. printk() is an expensive operation, esp. in
> low-level drivers (ask Paul what he'd like to do to those who put printk's
> in net driver interrupt handlers :P).
>
Point taken. This is still a work in progress and those messages are as much
about debugging the code - and the devices - as anything else (he says hoping
people with a few bizarre flash devices - anybody got one of those cameras? -
have a go).
Everybody assumes all flash chips on the DC are the same (1 partition, 256
blocks of 512 bytes) but there is no reason for them to be.
I think I'll removing them in 'production' code.
> M. R.
|
