Re: Input Device Key Mapping (driver authoring advice?)

[Vojtech P. <vo...@su...>]

On Wed, Jul 06, 2005 at 10:49:47AM -0400, Micah F. Galizia wrote:
> On Wed, 2005-06-07 at 15:55 +0200, Vojtech Pavlik wrote:
> [snip]
> > > 
> > > I used my best judgement when assigning keys, since the text on the
> > > device does not always match up with a key defined in input.h.  Here is
> > > a list of the potentially ambiguous or incorrect mappings:
> > > 
> > > Start->KEY_RED
> > > Pictures->KEY_MEDIA
> > > DVD Menu->KEY_MENU
> > > SAP->KEY_AUDIO
> > > Repeat->KEY_AGAIN
> > > CC/Teletext->KEY_SUBTITLE
> > > Music->KEY_MP3
> > 
> > The problem is that the markings on the device aren't important in case
> > of the Consumer HID usage page. We need to follow the spec
> > (http://www.usb.org/developers/devclass_docs/Hut1_11.pdf).
> > 
> > > Allow me to justify the silly ones.  The start key is big and red,
> > > Google told me SAP stands for "Secondary Audio Program", and there is no
> > > key close to pictures/graphics/image.
> > 
> > We can add KEY_* definitions, if they are likely to be used on other
> > devices, too.
> 
> Well, I am satisfied with these mappings.  They make sense (to me) for
> this device.  If you feel like adding keys for some of those buttons,
> I'll change it to use them.
> 
> > 
> > > The patch failed on account of HID_UP_LOGIVENDOR not being defined.  I
> > > fixed two hunks manually, so it should work fine with your tree,
> > > Vojtech.
> > 
> > Sorry for that, it's defined in an earlier patch I didn't send to you.
> > 
> > > Thanks again for all your help.  Please keep me posted if something is
> > > wrong.
> > 
> > > --- gitandhidpatches/drivers/usb/input/hid-input.c	2005-07-05 18:29:32.726219000 -0400
> > > +++ micah/drivers/usb/input/hid-input.c	2005-07-05 18:42:15.489888750 -0400
> > > @@ -237,6 +237,7 @@
> > >  				case 0x000: goto ignore;
> > >  				case 0x034: map_key_clear(KEY_SLEEP);		break;
> > >  				case 0x036: map_key_clear(BTN_MISC);		break;
> > > +				case 0x045: map_key_clear(KEY_RADIO);		break;
> > 
> > This is rather suspicious, considering what Consumer.0045 is supposed to
> > mean. I can add it, but I expect it'll be incorrect for other devices.
> 
> I am the appropriate authority to make this decision.  Now that I look
> at the spec, I see your point.  Its up to you, but in hindsight, I don't
> see much point in breaking the specifications.  If you add a
> KEY_MENU_RIGHT, I'll change it, if not, I wont.
> 
> > > -				case 0x209: map_key_clear(KEY_PROPS);		break;
> > > +				case 0x209: map_key_clear(KEY_INFO);		break;
> > 
> > See the spec on this one.
> 
> Yup, my bad.
> 
> Let me know what you want to do with ID 45 on the consumer page (and the
> other buttons), and I'll resubmit.

Keep the KEY_RADIO. It hasn't been mapped at all up to now, and I'll
change it if it's ever used on another device and somebody complains.


-- 
Vojtech Pavlik
SuSE Labs, SuSE CR